fix helper call removal

DataDog · Dec 2, 2024 · 6d8e725 · 6d8e725
1 parent 88565bb
commit 6d8e725
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/pkg/ebpf/perf/event.go b/pkg/ebpf/perf/event.go
@@ -189,6 +189,7 @@ func (e *EventHandler) BeforeInit(mgr *manager.Manager, moduleName names.ModuleN
 		e.initRingBuffer(mgr)
 		return nil
 	}
+	defer e.removeRingBufferHelperCalls(mgr, moduleName, mgrOpts)
 
 	if e.opts.mode == perfBufferOnly {
 		if ms.Type != ebpf.PerfEventArray {
@@ -212,13 +213,20 @@ func (e *EventHandler) BeforeInit(mgr *manager.Manager, moduleName names.ModuleN
 		}
 
 		e.initPerfBuffer(mgr)
-		// add helper call remover because ring buffers are not available
-		return ddebpf.NewHelperCallRemover(asm.FnRingbufOutput).BeforeInit(mgr, moduleName, mgrOpts)
+		return nil
 	}
 
 	return fmt.Errorf("unsupported EventHandlerMode %d", e.opts.mode)
 }
 
+func (e *EventHandler) removeRingBufferHelperCalls(mgr *manager.Manager, moduleName names.ModuleName, mgrOpts *manager.Options) {
+	if features.HaveMapType(ebpf.RingBuf) == nil {
+		return
+	}
+	// add helper call remover because ring buffers are not available
+	_ = ddebpf.NewHelperCallRemover(asm.FnRingbufOutput).BeforeInit(mgr, moduleName, mgrOpts)
+}
+
 func (e *EventHandler) setupConstant(mgrOpts *manager.Options) {
 	if e.opts.ringBufferConstantName == "" || e.f == nil {
 		return