Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
clarkb7 committed Jan 11, 2023
1 parent a348c2d commit 53f9090
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions comp/systray/systray/systray.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ var (

// newSystray creates a new systray component, which will start and stop based on
// the fx Lifecycle
func newSystray(deps dependencies) (Component, error) {
func newSystray(deps dependencies) Component {
// fx init
s := &systray{
log: deps.Log,
Expand All @@ -115,7 +115,7 @@ func newSystray(deps dependencies) (Component, error) {
s.isUserAdmin = isAdmin
}

return s, nil
return s
}

// start hook has a fx enforced timeout, so don't do long running things
Expand Down
2 changes: 1 addition & 1 deletion tasks/systray.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,6 @@ def clean(ctx):
# remove the bin/agent folder
print("Remove systray executable")
try:
os.remove('./bin/agent/ddtray.exe')
os.remove(os.path.join(BIN_PATH, bin_name("ddtray")))
except Exception as e:
print(e)

0 comments on commit 53f9090

Please sign in to comment.