Skip to content

Commit

Permalink
feat(secret): Prevent useless usage of Gitlab token
Browse files Browse the repository at this point in the history
  • Loading branch information
chouetz committed Oct 8, 2024
1 parent 1238b9b commit 52b4c2a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion .gitlab/e2e/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,6 @@ generate-flakes-finder-pipeline:
- qa_agent_ot
tags: ["arch:amd64"]
script:
- GITLAB_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $GITLAB_FULL_API_TOKEN) || exit $?; export GITLAB_TOKEN
- inv -e testwasher.generate-flake-finder-pipeline
artifacts:
paths:
Expand Down
1 change: 0 additions & 1 deletion .gitlab/kernel_matrix_testing/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,5 @@ notify_ebpf_complexity_changes:
- python3 -m pip install tabulate # Required for printing the tables
- python3 -m pip install -r tasks/libs/requirements-github.txt
- !reference [.setup_agent_github_app]
- GITLAB_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $GITLAB_FULL_API_TOKEN) || exit $?; export GITLAB_TOKEN
script:
- inv -e ebpf.generate-complexity-summary-for-pr
2 changes: 1 addition & 1 deletion tasks/testwasher.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def generate_flake_finder_pipeline(ctx, n=3):
"""

# Read gitlab config
config = resolve_gitlab_ci_configuration(ctx, ".gitlab-ci.yml")
config = resolve_gitlab_ci_configuration(ctx, ".gitlab-ci.yml", with_lint=False)

# Lets keep only variables and jobs with flake finder variable
kept_job = {}
Expand Down

0 comments on commit 52b4c2a

Please sign in to comment.