Fix glog logger conflict (#1310)

* moving glog flag parsing to start of the agent to avoid conflict of loggers
DataDog · Feb 21, 2018 · 3fa016c · 3fa016c
1 parent 324cf18
commit 3fa016c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/pkg/util/kubernetes/apiserver/leaderelection/leaderelection.go b/pkg/util/kubernetes/apiserver/leaderelection/leaderelection.go
@@ -179,5 +179,7 @@ func (le *LeaderEngine) IsLeader() bool {
 func init() {
 	// Avoid logging glog from the k8s.io package
 	flag.Lookup("stderrthreshold").Value.Set("FATAL")
-	flag.Parse()
+	//Convinces goflags that we have called Parse() to avoid noisy logs.
+	//OSS Issue: kubernetes/kubernetes#17162.
+	flag.CommandLine.Parse([]string{})
 }
diff --git a/releasenotes/notes/fix-logger-glog-80cfbb7958da4c64.yaml b/releasenotes/notes/fix-logger-glog-80cfbb7958da4c64.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Fix the command-line flag parsing regression caused by a transitive dependency importing the
+    glog library. `agent` flags should now behave as in beta9.