move decoded into tcpParser

DataDog · Oct 16, 2024 · 2b97362 · 2b97362
1 parent 6dade5e
commit 2b97362
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/networkpath/traceroute/tcp/utils.go b/pkg/networkpath/traceroute/tcp/utils.go
@@ -312,6 +312,7 @@ func parseICMP(header *ipv4.Header, payload []byte) (*icmpResponse, error) {
 
 type tcpParser struct {
 	layer               layers.TCP
+	decoded             []gopacket.LayerType
 	decodingLayerParser *gopacket.DecodingLayerParser
 }
 
@@ -327,8 +328,7 @@ func (tp *tcpParser) parseTCP(header *ipv4.Header, payload []byte) (*tcpResponse
 		return nil, fmt.Errorf("invalid IP header for TCP packet: %+v", header)
 	}
 
-	var decoded []gopacket.LayerType
-	if err := tp.decodingLayerParser.DecodeLayers(payload, &decoded); err != nil {
+	if err := tp.decodingLayerParser.DecodeLayers(payload, &tp.decoded); err != nil {
 		return nil, fmt.Errorf("failed to decode TCP packet: %w", err)
 	}