-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove entrypoint from all Agent build images #370
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
902baff
[deb-x64] Remove entrypoint
KSerrania 0b8b060
[deb-arm] Remove entrypoint
KSerrania b1b8ec0
Fix rvm setup
KSerrania 3aaa3b6
[rpm-x64] Remove entrypoint
KSerrania 86bc51d
[rpm-arm64] Remove entrypoint
KSerrania e89ba7b
[rpm-armhf] Remove entrypoint
KSerrania 615b8c3
[suse-x64] Remove entrypoint
KSerrania e1a1bf4
Remove unused line in test jobs
KSerrania 572a662
[deb-x64] Fix go path setup
KSerrania 5199fa1
Merge branch 'main' into kserrania/remove-entrypoint
KSerrania 045ac73
Merge remote-tracking branch 'origin/main' into kserrania/remove-entr…
KSerrania 5ecd649
Merge remote-tracking branch 'origin/main' into kserrania/remove-entr…
KSerrania File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why rpm is split between arm64 and armhf, and not the same for deb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. It boils down to similarity between the base images.
For the
deb
images, we usearm64v8/ubuntu:16.04
andarm32v7/ubuntu:16.04
as base images. Since that's the same OS & version, most commands are the same (with only a few differences), which allowed for merging the image definitions.For the
rpm
images, we useamazonlinux:2.0.20181114
andarm32v7/centos:7
as base images (for reasons described here). These are different OSes, which implies some more differences in the image build processes, so to be safe these were separated in two files.I don't think the steps done in the two
rpm
Dockerfiles are quite different nowadays, so we could look into merging them - that's mainly a matter of preference / legibility of the Dockerfiles.