Break install-all into phases to allow for some Docker layers #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change env var helpers to write to USER env instead of SYSTEM env
iglendd
approved these changes
Feb 1, 2023
Comment on lines
+68
to
+75
| COPY ./windows/helpers/phase1/*.ps1 c:/scripts/helpers/phase1/ | ||
| RUN .\install-all.ps1 -TargetContainer -Phase 1 | ||
| COPY ./windows/helpers/phase2/*.ps1 c:/scripts/helpers/phase2/ | ||
| RUN .\install-all.ps1 -TargetContainer -Phase 2 | ||
| COPY ./windows/helpers/phase3/*.ps1 c:/scripts/helpers/phase3/ | ||
| RUN .\install-all.ps1 -TargetContainer -Phase 3 | ||
| COPY ./windows/helpers/phase4/*.ps1 c:/scripts/helpers/phase4/ | ||
| RUN .\install-all.ps1 -TargetContainer -Phase 4 |
There was a problem hiding this comment.
Is it possible to have a more meaningful names instead of numbers (I wonder)
clarkb7
added a commit
that referenced
this pull request
Feb 7, 2023
Change env var helpers to write to USER env instead of SYSTEM env
derekwbrown
added a commit
that referenced
this pull request
Feb 16, 2023
…#276) * DO NOT MERGE Initial revision. Attempting single run windows container, in hopes of being able to make shared environment script * fix path location (vcpkg) * temp stop before vcpkg for debugging * fix path error in networking script * fix vcpkg * fix go entry in path * make work on local system * fix typo in gsdk * debugging statement for vcpkg * remove ridk enable; fixes calls to cmd * Working both locally and in container * clean up python handling fix error in go path finding Attempt to catch msys install failure :Add some debugging for 2022ltsc Move mingit after vstudio fix path to patch * Break install-all into phases to allow for some Docker layers (#346) Change env var helpers to write to USER env instead of SYSTEM env * Apply suggestions from code review Co-authored-by: Julien Lebot <[email protected]> * fix dockerfile syntax * Fix go SHA256 Ensure Get-RemoteFile can handle empty env vars --------- Co-authored-by: Branden Clark <[email protected]> Co-authored-by: Julien Lebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break install-all into phases to allow for some Docker layers
Keep
mainbehavior in env var helpers and write to USER env instead of SYSTEM envvs_buildtools.exe