Remove system-probe images entrypoint #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcacheux
force-pushed
the
paulcacheux/system-probe-entrypoints
branch
2 times, most recently
from
797cd07 to
d0641d1
Compare
paulcacheux
force-pushed
the
paulcacheux/system-probe-entrypoints
branch
from
1505300 to
f36eff1
Compare
brycekahle
reviewed
Jan 26, 2023
brycekahle
approved these changes
Jan 26, 2023
|
Thanks, I will merge this once the freeze on the agent side is lifted |
bkabrda
approved these changes
Feb 2, 2023
10 tasks
10 tasks
KSerrania
added a commit
that referenced
this pull request
Jun 13, 2023
Updates the deb-x64, deb-arm64, deb-armhf, rpm-x64, rpm-arm64, rpm-armhf, suse-x64 images and removes their entrypoint. This PR: - removes the use of `gimme` to install go (same as what was done to remove entrypoints in the system-probe images in #292). Installing go from source is easier (since we only need one go version), and has the benefit of not having to run `gimme <go version>` to enable the use of a go version (which we used to do in the entrypoint script) - removes the entrypoint scripts in images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system-probe images use the entrypoint to setup the gimme go version. With a potential future move to k8s runners, we will need to not use entrypoints since those are not supported. This PR removes the system probe entrypoints by installing golang manually, and setting up the
*PATHmanually as well.Agent pipeline: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/12800264
--> the jobs to look for are
build_system_probe*,build_clang*,tests_ebpf*,security_go_generate_checkand dependents