Issue 748: conflit with gpnupg2 on centos8

[haidars]

Issue #748

• Add guards on while installing gnupg to avoid conflit with gnupg2 on RHEL/Centos8

[mx-psi]

Thanks for the PR! The PR code looks good to me but you will need the CI pass so that we can merge this. In particular you need to update the spec tests to account for this change. You can run the tests locally following these guidelines.

[haidars]

Thanks for the PR! The PR code looks good to me but you will need the CI pass so that we can merge this. In particular you need to update the spec tests to account for this change. You can run the tests locally following these guidelines.

Spec file has been updated to reflect the changes.

[mx-psi]

We still install gnupg on some situations so we want to keep the spec test. One way to reflect what you did in the code is:

      it 'installs gnupg' do
        expect(chef_run).to install_package('gnupg') if chef_run.node['packages']['gnupg2'].nil?
      end

Would you mind adding back the spec tests following that pattern?

[haidars]

Of course... will do that in the evening...

[haidars]

Done for unit test

[mx-psi]

Awesome, thanks for taking the time to fix that!

[mx-psi]

LGTM, thank you again! 🚀