Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Malformed version number string" for nightlies #712

Merged
merged 2 commits into from
May 13, 2020
Merged

Fix "Malformed version number string" for nightlies #712

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0f7190
Fix "Malformed version number string" for nightlies
albertvaka May 13, 2020
e75ce1b
Make linter happy
albertvaka May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libraries/recipe_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,10 @@ def fetch_current_version
agent_status = `"#{WIN_BIN_PATH}" status`
match_data = agent_status.match(/^Agent \(v(.*)\)/)

Gem::Version.new(match_data[1]) if match_data
# Nightlies like 6.20.0-devel+git.38.cd7f989 fail to parse as Gem::Version because of the '+' sign
version = match_data[1].tr('+', '-')

Gem::Version.new(version) if version
end

def requested_agent_version(node)
Expand Down