Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice for Chef < 12.7 users. #598

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Notice for Chef < 12.7 users. #598

merged 1 commit into from
Mar 27, 2019

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Mar 25, 2019

We will soon drop support for Chef < 12.7, adds a notice for users still using those versions.

@remeh remeh added this to the 3.0 milestone Mar 25, 2019
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, but LGTM!

@@ -32,6 +32,9 @@ Requirements
============
- chef >= 10.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to update this to 12.7 as well (so that master reflects the support of the latest release)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely (this has already been covered in #450 which is the one actually dropping the support for < 12.7)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh well, thanks, disregard then :)

@remeh remeh added the ready label Mar 25, 2019
@remeh remeh merged commit 55bd85f into master Mar 27, 2019
@remeh remeh deleted the remeh/notice-3.0 branch March 27, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants