Mongo & Elasticsearch: extend config templates with more options #424
Conversation
There was a problem hiding this comment.
Thanks @gkze for your contribution!
There's an issue with the indentation of the options you added, could you fix it?
templates/default/elastic.yaml.erb
Outdated
| @@ -7,6 +7,9 @@ instances: | |||
| <% unless i["pshard_stats"].nil? %> | |||
| pshard_stats: <%= i["pshard_stats"] %> | |||
| <% end %> | |||
| <% unless i["cluster_stats"].nil? %> | |||
| cluster_stats: <%= i["cluster_stats"] %> | |||
There was a problem hiding this comment.
the indentation is not correct here: cluster_stats needs to have the same indentation as the other parameters. Could you correct it?
(same comment for the ssl options of mongo.yaml.erb)
|
Good catch @olivielpeau, thank you. Corrected. |
There was a problem hiding this comment.
Thanks @gkze! Looks good now 👌
The CI failures are unrelated to your changes, I'll try to find some time to fix them first and then merge your PR
|
For some reason I can't make the CI to re-run against a merge of this PR into the current state of master, so the build still fails. Merging this, I'll check that the resulting CI build on master is successful. Thanks @gkze! |
|
Thank you @olivielpeau 👍 |
We need these options in production and are currently overriding the config. We'd like to have these available to configure.