Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for collect_function_metrics key #302

Closed
wants to merge 1 commit into from

Conversation

kellym
Copy link

@kellym kellym commented May 1, 2016

This fixes the postgres template file when when checking for collect_function_metrics.

@miketheman miketheman added this to the Next minor milestone May 2, 2016
@miketheman
Copy link
Contributor

Hi @kellym ! Thanks for the fix.

We've been (slowly) porting over template generation slow integration tests to speedy spec tests - see #295 for an example.
Could you take a pass at converting the postgres one to support this change?

miketheman added a commit that referenced this pull request May 3, 2016
- Use correct `.key?` syntax, Fix #300
- Emit correct boolean, introduced in #278
- Add postgres spec test

Closes #302

Signed-off-by: Mike Fiedler <[email protected]>
@miketheman miketheman removed this from the Next minor milestone May 3, 2016
miketheman added a commit that referenced this pull request May 4, 2016
- Use correct `.key?` syntax, Fix #300
- Emit correct boolean, introduced in #278
- Add postgres spec test

Closes #302

Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants