-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory check integration #277
Conversation
This looks great, I'd love to start using this on several of my datadog installations. |
@kindlyseth Would you consider porting the Kitchen test to a Spec test? See here for an example. Specs are much "cheaper" to run overall, and validate template renderings just as much as the kitchen tests do. My hope is that we'll port over all existing kitchen tests to specs, and some of the effort has started, so I'd like to not introduce more if possible. |
Yep, I'll try to find time early next week. |
@miketheman, I think the CircleCI check is not my error. Looks like it might need a version bump that's probably been done on master, but I didn't know if it was worth it to rebase and do a new PR. |
@kindlyseth Thanks! I've rebased and squashed to a single commit here: https://github.com/DataDog/chef-datadog/compare/kindlyops-directory?expand=1 If it passes CI, then it's ripe for merge, and I'll take it from there. Thanks! |
Thanks! |
Thank you! |
This pull request adds support for the standard directory check integration, http://docs.datadoghq.com/integrations/directory/ .