[core] More global contexts #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
force-pushed
the
yoann/more-global-contexts
branch
from
90a23db
to
b7ac51c
Compare
yoannmoinet
changed the base branch from
yoann/rum-plugin
to
yoann/refactor-testing-telemetry
yoannmoinet
requested review from
sarenji and
elbywan
and removed request for
a team and
sarenji
elbywan
approved these changes
Jul 10, 2024
yoannmoinet
commented
Jul 10, 2024
| @@ -45,7 +46,8 @@ export const getWebpack4Options = ( | |||
| const plugin = datadogWebpackPlugin(newPluginOptions) as unknown; | |||
|
|
|||
| return { | |||
| entry: defaultEntry, | |||
| // Somehow webpack4 doesn't find @dd/tests/fixtures/index.js | |||
There was a problem hiding this comment.
I think it's simply that it doesn't support pnp without a plugin.
Base automatically changed from
yoann/refactor-testing-telemetry
to
yoann/rum-plugin
July 10, 2024 14:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #85
What and why?
We need a way to communicate the list of files produced at the end of the build.
How?
We're using the global context plugin to gather the list from webpack and esbuild (since they are the only two bundles we support right now).
And add it to the global context.