Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Option to Include Similar Nodegroups in Expander Options #112

Draft
wants to merge 1 commit into
base: datadog-master-12.0
Choose a base branch
from

Conversation

BenHinthorne
Copy link

@BenHinthorne BenHinthorne commented Jun 14, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the gRPC expanders Options request to include SimilarNodegroupIds. The purpose of adding this option is two fold:

  • So that users can use the similar nodegroups as part of their best options filtering via the gRPC expander.
  • When used alongside the flag introduced in this PR (todo: link to Rahul's PR), this would allow users to also filter which similar nodegroups would be included as part of the option. This allows for a more granular customization of the scaling options by the user, via their custom gRPC expander.

An example use case for why users may want to filter the similar nodegroups in the gRPC expander is to filter nodegroups by a maximum number of nodes per zone, to prevent scaling in zones that experience IP Exhaustion (link issue). Another example would be that this allows users to prevent upscaling in zones in which they may have an outage, via filtering out these options via their gRPC expander.

It's also worth noting that the the other built-in expanders have SimilarNodegroups included by default, because the expander.Option type includes similar nodegroups, it was only the *protos.Option type which did not.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@BenHinthorne BenHinthorne force-pushed the benh/update-expander-proto branch 2 times, most recently from e17c1e7 to 4518ba3 Compare June 14, 2024 15:56
@BenHinthorne BenHinthorne changed the title desparately trying to figure out how to use protoc Introduce Option to Include Similar Nodegroups in Expander Options Jun 14, 2024
@BenHinthorne BenHinthorne force-pushed the benh/update-expander-proto branch 4 times, most recently from 841a011 to c6af2c9 Compare June 18, 2024 20:09
@BenHinthorne BenHinthorne force-pushed the benh/update-expander-proto branch from c6af2c9 to 614aa68 Compare June 18, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants