Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation when a version is pinned and the installer is enabled #609

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

chouquette
Copy link
Contributor

No description provided.

@chouquette chouquette force-pushed the chouquette/install_over_existing branch from e5f05c9 to 1b7ff10 Compare September 10, 2024 07:23
@chouquette chouquette force-pushed the chouquette/install_over_existing branch 2 times, most recently from ccc3a71 to 0523fa8 Compare September 10, 2024 08:25
@chouquette chouquette force-pushed the chouquette/install_over_existing branch from 0523fa8 to ca7029b Compare September 10, 2024 08:26
These are also responsible for setting up the installer, and doing some
bookkeeping around our GPG keys.
The installation of the agent package itself is already gated behind
agent_datadog_skip_install, so we won't attemp to reinstall the agent if
it's already installed to the latest version.
However we will now correctly probe for the installer ownership.
This should fix #603
@chouquette chouquette marked this pull request as ready for review September 10, 2024 09:18
@chouquette chouquette requested a review from a team as a code owner September 10, 2024 09:18
@chouquette chouquette changed the title add a pre-existing install of the agent to the installer tests Fix installation when a version is pinned and the installer is enabled Sep 10, 2024
Copy link
Contributor

@Pythyu Pythyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM 👍

.circleci/config.yml Show resolved Hide resolved
tasks/main.yml Show resolved Hide resolved
@chouquette chouquette merged commit aaced7a into main Sep 12, 2024
156 checks passed
@chouquette chouquette deleted the chouquette/install_over_existing branch September 12, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants