Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken Ansible Galaxy URLs #580

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

kaveet
Copy link
Contributor

@kaveet kaveet commented Jul 5, 2024

Two URLs in README point to slightly incorrect pages in Ansible Galaxy.

  1. Points to the agent role, but not the one in the datadog.datadog namespace
  2. Broken entirely

Two URLs in README point to slightly incorrect pages in Ansible Galaxy.
@kaveet kaveet requested review from a team as code owners July 5, 2024 00:54
@kaveet kaveet changed the title fix: update broken Ansible Galaxy URLs Update broken Ansible Galaxy URLs Jul 5, 2024
@michaelcretzman
Copy link

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 5, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 0s.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Jul 5, 2024

MergeQueue: The checks failed on this merge request

Tests failed on this commit f91ac1b

You should fix those tests and then re-add your pull request to the queue!

Details

some checks are failing:

If you need support, contact us on Slack #devflow with those details!

@@ -7,7 +7,7 @@ The Datadog Agent Ansible role installs and configures the Datadog Agent and int
The Datadog Agent Ansible role is available through 2 different channels:

* As part of the Datadog collection, accessible under the [datadog.dd](https://galaxy.ansible.com/ui/repo/published/datadog/dd/) name on Ansible Galaxy (recommended).
* As a standalone role, accessible under the [datadog.datadog](https://galaxy.ansible.com/ui/repo/published/datadog/dd/content/role/agent/) name on Ansible Galaxy (legacy).
* As a standalone role, accessible under the [datadog.datadog](https://galaxy.ansible.com/ui/standalone/roles/DataDog/datadog/) name on Ansible Galaxy (legacy).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥜 nitpick: ‏We could reuse the existing link here

Suggested change
* As a standalone role, accessible under the [datadog.datadog](https://galaxy.ansible.com/ui/standalone/roles/DataDog/datadog/) name on Ansible Galaxy (legacy).
* As a standalone role, accessible under the [datadog.datadog][1] name on Ansible Galaxy (legacy).

@spencergilbert
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 9, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 0s.

Use /merge -c to cancel this operation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants