Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mode to string parameters #528

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Change mode to string parameters #528

merged 1 commit into from
Feb 20, 2024

Conversation

janorn
Copy link
Contributor

@janorn janorn commented Nov 13, 2023

Update playbook to use string type on mode parameter.

Fixes #527

@janorn janorn requested a review from a team as a code owner November 13, 2023 11:02
@janorn
Copy link
Contributor Author

janorn commented Dec 5, 2023

From Ansible docs:

For those used to /usr/bin/chmod remember that modes are actually octal numbers. You must give Ansible enough information to parse them correctly. For consistent results, quote octal numbers (for example, '644' or '1777') so Ansible receives a string and can do its own conversion from string into number. Adding a leading zero (for example, 0755) works sometimes, but can fail in loops and some other circumstances.

For those used to /usr/bin/chmod remember that modes are actually octal numbers. You must give Ansible enough information to parse them correctly. For consistent results, quote octal numbers (for example, '644' or '1777') so Ansible receives a string and can do its own conversion from string into number. Adding a leading zero (for example, 0755) works sometimes, but can fail in loops and some other circumstances.
@janorn
Copy link
Contributor Author

janorn commented Dec 5, 2023

Rebased and squashed commits

@janorn
Copy link
Contributor Author

janorn commented Dec 5, 2023

@chouetz anything else needed for this to be reviewed?

Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thanks a lot for the PR!

@bkabrda bkabrda merged commit 7ecd415 into DataDog:main Feb 20, 2024
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mode 600 will set incorrect permissions on files.
2 participants