-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configuring APM injection #481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋 thanks for sending a PR. I think this is a good start, but it will need some more work. I left comments inline addressing what needs to be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋 thanks for the additional work, this looks much better now! I left couple comments to address inline. I would also like to ask you to add the descriptions of all newly added configuration values to the README.md
file.
…iner-only install.
… installs for now
8988bdf
to
b82343d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small edit
Co-authored-by: Heston Hoffman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋 this now looks almost ready, but I still found some problems that should be addressed before I can approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, great job!
Hi didnt you forgot the Agent on host, app in containers possibillity of injecting APM? |
This PR adds support for configuring APM injection for a host (see: https://docs.datadoghq.com/tracing/trace_collection/library_injection_local/?tab=host#configure-docker-injection).
The supported scenarios are:
datadog_apm_instrumentation_enabled: host
).datadog_apm_instrumentation_enabled: docker
).datadog_apm_instrumentation_enabled: all
).