-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NPM support for Windows #326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
reviewed
Mar 4, 2021
leeavital
reviewed
Mar 4, 2021
leeavital
reviewed
Mar 4, 2021
ruthnaebeck
suggested changes
Mar 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs review
Co-authored-by: Lee Avital <[email protected]>
Co-authored-by: Lee Avital <[email protected]>
Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: Albert Vaca Cintora <[email protected]>
bkabrda
pushed a commit
that referenced
this pull request
Mar 23, 2021
KSerrania
pushed a commit
that referenced
this pull request
Mar 23, 2021
* update readme to reflect changes * Update README.md Co-authored-by: Lee Avital <[email protected]> * Update README.md Co-authored-by: Lee Avital <[email protected]> * Update README.md Co-authored-by: ruthnaebeck <[email protected]> * Update README.md Co-authored-by: ruthnaebeck <[email protected]> * Update tasks/pkg-windows-opts.yml Co-authored-by: ruthnaebeck <[email protected]> * Update templates/system-probe.yaml.j2 Co-authored-by: ruthnaebeck <[email protected]> * Update templates/system-probe.yaml.j2 Co-authored-by: ruthnaebeck <[email protected]> * Update README.md Co-authored-by: ruthnaebeck <[email protected]> * Update tasks/pkg-windows-opts.yml Co-authored-by: Albert Vaca Cintora <[email protected]> Co-authored-by: Lee Avital <[email protected]> Co-authored-by: ruthnaebeck <[email protected]> Co-authored-by: Albert Vaca Cintora <[email protected]>
KSerrania
added a commit
that referenced
this pull request
Mar 24, 2021
Redo of #326, with fixes to avoid undefined variable problems on Windows. Co-authored-by: Derek Brown <[email protected]> Co-authored-by: Lee Avital <[email protected]> Co-authored-by: ruthnaebeck <[email protected]> Co-authored-by: Albert Vaca Cintora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NPM support for windows
Updates configuration for
network_config
section of datadog.yamlUpdate readme to match.