Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow rake to remove toolchaing, clean before testing #350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow rake to remove toolchaing, clean before testing #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ protoc_jsonschema_version="73d5723"
namespace :codegen do
task :clean do
sh "rm -rf #{gogo_dir}"
if Dir.exist?(toolchain_dir)
sh "chmod u+w -R #{toolchain_dir}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quetsion: Would it make more sense to add the permissions in the task that generates the proto files?

end
sh "rm -rf #{toolchain_dir}"
end

Expand Down Expand Up @@ -174,7 +177,7 @@ task :deps do
end

desc "Run tests"
task :test do
task :test => ['codegen:clean'] do
cmd = "go list ./... | grep -v vendor | xargs go test -v "
sh cmd
end
Expand Down
Loading