Aggregate() for Connections, ConnectionsTelemetry #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeavital
reviewed
May 2, 2023
| @@ -142,3 +142,46 @@ func (m *CollectorConnections) GetConnectionsTags(tagIndex int32) []string { | |||
| func (m *CollectorConnections) UnsafeIterateConnectionTags(tagIndex int32, cb func(i, total int, tag []byte) bool) { | |||
| unsafeIterateTags(m.EncodedConnectionsTags, int(tagIndex), cb) | |||
| } | |||
|
|
|||
| // Aggregate telemetry counters | |||
| func (t *ConnectionsTelemetry) Aggregate(a *ConnectionsTelemetry) { | |||
There was a problem hiding this comment.
You should probably add a comment in the proto file indicating that this method needs to be updated whenever fields are added; the next person is probably going to forget
nplanel
force-pushed
the
nplanel/connections-aggregate
branch
from
4354c04
to
ff96ca8
Compare
10 tasks
leeavital
approved these changes
May 12, 2023
nplanel
force-pushed
the
nplanel/connections-aggregate
branch
from
ff96ca8
to
3c46f51
Compare
nplanel
force-pushed
the
nplanel/connections-aggregate
branch
from
3c46f51
to
86c8dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: please see the review guidelines.