Add container image protocol buffer definitions #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L3n41c
force-pushed
the
lenaic/contimage
branch
from
5586ab6 to
6c96fdf
Compare
davidor
reviewed
Nov 30, 2022
mbotarro
reviewed
Dec 1, 2022
to be consistent with what containerd returns.
10 tasks
mbotarro
reviewed
Dec 16, 2022
mbotarro
reviewed
Dec 16, 2022
sgnn7
approved these changes
Jan 3, 2023
| } | ||
|
|
||
| // ContainerImage contains the details of a container image | ||
| message ContainerImage { |
There was a problem hiding this comment.
Out of the scope of my understanding on the details of this feature and not a blocker but would adding content trust fields around the image tags be valuable here since it can be used to identify modified images/layers?
robertjli
approved these changes
Jan 4, 2023
clamoriniere
approved these changes
Jan 4, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: please see the review guidelines.
This payload is further described in the “Container images vulnerabilities” RFC.