Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent pluralization, Metric Sample -> Series #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use consistent pluralization, Metric Sample -> Series #12

wants to merge 1 commit into from

Conversation

elijahandrews
Copy link

@elijahandrews elijahandrews commented Aug 7, 2017 •
edited
Loading

I think that these are better names for these messages

olivielpeau
olivielpeau approved these changes Aug 7, 2017
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

These changes will have to be reflected on datadog-agent, let me know if you'd like me to take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes

@Arkelenia Arkelenia Awaiting requested review from Arkelenia

@jmoiron jmoiron Awaiting requested review from jmoiron

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elijahandrews @olivielpeau