Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixing broken pipeline #6

Merged
merged 6 commits into from
Aug 1, 2024
Merged

chore: fixing broken pipeline #6

merged 6 commits into from
Aug 1, 2024

Conversation

kkiani
Copy link
Contributor

@kkiani kkiani commented Jul 31, 2024 •
edited
Loading

Description

The pipeline is broken. This PR provide fixes and some tests to make the pipeline green.

  • add some basic test so pipeline does not complain with no test found.
  • disable mypy checking pulumi types as it is too slow and throwing timout.
  • adding pyright as alternative to typechecking along with mypy.

@kkiani kkiani changed the title chore: add tests for build/run time decorators chore: add tests Jul 31, 2024
@kkiani kkiani changed the title chore: add tests chore: fixing broken pipeline Jul 31, 2024
@kkiani kkiani force-pushed the feature/adding-tests branch 2 times, most recently from e80d955 to e0bc5d3 Compare August 1, 2024 07:52
shahinism
shahinism approved these changes Aug 1, 2024
View reviewed changes
.test.sh Show resolved Hide resolved
@kkiani kkiani merged commit 1b567ce into main Aug 1, 2024
2 checks passed
@kkiani kkiani deleted the feature/adding-tests branch August 1, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahinism shahinism shahinism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkiani @shahinism