Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add details of the framework to the README #3

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Conversation

kkiani
Copy link
Contributor

@kkiani kkiani commented Jul 26, 2024

Description

The PR adds detailed description and information about the project

@kkiani kkiani force-pushed the feature/readme branch 2 times, most recently from fa754fb to ec04cf2 Compare July 26, 2024 09:27
@kkiani kkiani requested a review from shahinism July 26, 2024 10:15
@kkiani kkiani force-pushed the feature/readme branch 5 times, most recently from dd03485 to aba7480 Compare July 26, 2024 11:18
@kkiani kkiani linked an issue Sep 9, 2024 that may be closed by this pull request
6 tasks
README.md Outdated Show resolved Hide resolved
@callarelli93
Copy link
Collaborator

I think it's ok for now but as we discussed before Damavand is first thing an implementation of the ARC pattern, so we would need to have a post explaining in detail ARC and putting that at the start to clarify. Otherwise I feel that devs would be put off by learning yet another framework

Co-authored-by: Andrea Callarelli <[email protected]>
@kkiani
Copy link
Contributor Author

kkiani commented Oct 7, 2024

I think it's ok for now but as we discussed before Damavand is first thing an implementation of the ARC pattern, so we would need to have a post explaining in detail ARC and putting that at the start to clarify. Otherwise I feel that devs would be put off by learning yet another framework

@callarelli93 I totally agree. We will serve documentation for ARC independent of Damavand on a separate host as we discussed before and then I will add the links here. But I also think we can move on with this for now.

@kkiani kkiani merged commit 6e67f86 into main Oct 7, 2024
2 checks passed
@kkiani kkiani deleted the feature/readme branch October 7, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add README file
2 participants