argon2id Password Hashing #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added argon module to requirements, commented bcrypt out - Added argon hashing to login - Added argon hashing to register
With amended hashes, operational behaviour should just be plug and play. Tested successfully with all 5 Basiq Test personas Actually easier, better and more secure than bcrypt :)
Signed-off-by: wongaid <[email protected]>
|
|
Removed log and debug points removed `hashed`, returned to pre-pull state that overwrites `input_password`. Avoids leaving password being exposed in Plaintext in mem.
…ataBytes-Organisation/Neo_Dolfin into feature_FLASK_argon2id_hashing
SDzartov
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple bcrypt.
Shift hashing flows from bcrypt to argon2 - "id" format. Works in strings or bytes, making readability easier and less messing around with string encoding and DB compatibility etc.
Updated requirements.txt, and added new argon hashes to test user database. No new records required. Continue to use same passwords for testing.