Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filestore bypass #3652

Merged
merged 85 commits into from
Jul 16, 2021
Merged

Allow filestore bypass #3652

merged 85 commits into from
Jul 16, 2021

Conversation

adamnovak
Copy link
Member

@adamnovak adamnovak commented Jun 16, 2021

Changelog Entry

To be copied to the draft changelog by merger:

  • --bypass-file-store lets toil-cwl-runner support inplaceUpdateRequirement

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/cliOptions.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passes tests.
  • Make sure the PR has been reviewed since its last modification. If not, review it.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

adamnovak added 30 commits May 20, 2021 16:22
@adamnovak
Copy link
Member Author

OK @DailyDreaming, I've written a better message that explains what you should need to get InplaceUpdateRequirement working.

Copy link
Member

@DailyDreaming DailyDreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamnovak Thanks. This looks good to me, provided the comments in the PR this is based on are addressed (#3628).

@adamnovak adamnovak mentioned this pull request Jun 26, 2021
19 tasks
@adamnovak
Copy link
Member Author

When this is finally done it will probably fix #3667.

@adamnovak adamnovak merged commit f194cbf into master Jul 16, 2021
@mr-c mr-c deleted the issues/3651-allow-filestore-bypass branch July 17, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement InplaceUpdateRequirement for CWL with FileJobStore
3 participants