-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix python3 string/bytes error when using --printLogs #3005
fix python3 string/bytes error when using --printLogs #3005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I'll pull it in for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnbradley Thanks for putting in this fix!
The Gitlab tests are all failing due to the absence of the
Between the last successful job and this one we changed from setuptools 45 to 56. In 46 they removed We either need to make Toil require setuptools <46, or fix http-parser and pymesos. |
Test to reproduce `TypeError: can only concatenate str (not "bytes") to str` error.
Fix for problem raised in issue DataBiosphere#3004
502343d
to
014dcba
Compare
OK I stacked this on top of current master which passed CI; I think this will pass too. |
Adds
decode('utf-8')
method call to fix the following error:This fix is already being used in leader.py FailedJobsException:
toil/src/toil/leader.py
Lines 79 to 80 in 993be0c
Let me know if you would prefer a new function to abstract out this duplication.
For testing the bug I added an example CWL workflow that always fails.
Fixes problem raised in #3004