Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Unit without value for donor age in project 5f607e50 (#5264) #5265

Merged

Conversation

achave11-ucsc
Copy link
Member

@achave11-ucsc achave11-ucsc commented Jun 2, 2023

Connected issue: #5264

Checklist

Author

  • Target branch is prod
  • Name of PR branch matches hotfixes/<GitHub handle of author>/<issue#>-<slug>
  • PR title references the connected issue
  • PR title is Hotfix: followed by title of connected issue
  • PR is connected to issue via ZenHub
  • PR description links to connected issue

Author (hotfixes)

  • Added h tag to commit title or this PR does not include a temporary hotfix
  • Added H tag to commit title or this PR does not include a permanent hotfix
  • Added hotfix label to PR
  • Added partial label to PR or this PR is a permanent hotfix

Author (before every review)

  • Rebased PR branch on prod, squashed old fixups
  • Ran make requirements_update or this PR does not touch requirements*.txt, common.mk, Makefile and Dockerfile
  • Added R tag to commit title or this PR does not touch requirements*.txt
  • Added reqs label to PR or this PR does not touch requirements*.txt

Primary reviewer (after approval)

  • Actually approved the PR
  • Labeled PR as no sandbox
  • PR title is appropriate as title of merge commit
  • Moved ticket to Approved column
  • Assigned PR to current operator

Operator (before pushing merge the commit)

  • Squashed PR branch and rebased onto prod
  • Sanity-checked history
  • Pushed PR branch to GitHub
  • Title of merge commit starts with title from this PR
  • Added PR reference to merge commit title
  • Added commit title tags to merge commit title
  • Moved connected issue to Merged prod column in ZenHub
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab prod
  • Build passes on GitLab prod
  • Reviewed build logs for anomalies on GitLab prod
  • Deleted PR branch from GitHub
  • Deleted PR branch from GitLab prod

Operator (reindex)

  • Delete source hca_prod_5f607e50ba224598b1e9f3d9d7a35dcc__20230201_dcp2_20230531_dcp28 in prod or this PR does not remove catalogs or otherwise causes unreferenced indices
  • Started reindex in prod or neither this PR nor a prior failed promotion requires it
  • Checked for and triaged indexing failures in prod or neither this PR nor a prior failed promotion requires it
  • Emptied fail queues in prod deployment or neither this PR nor a prior failed promotion requires it
  • Created backport PR and linked to it in a comment on this PR

Operator

  • Unassigned PR

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@github-actions github-actions bot added the orange [process] Done by the Azul team label Jun 2, 2023
@achave11-ucsc achave11-ucsc added the hotfix [process] An PR with an urgent fix for prod label Jun 2, 2023
@coveralls
Copy link

Coverage Status

coverage: 84.435%. remained the same when pulling 7b45ebd on hotfixes/achave11-ucsc/5264-remove-offending-project into d3f0062 on prod.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #5265 (7b45ebd) into prod (d3f0062) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             prod    #5265   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         149      149           
  Lines       18305    18305           
=======================================
  Hits        15452    15452           
  Misses       2853     2853           

@achave11-ucsc achave11-ucsc changed the title Hotfix: Metadata for donor_organism lacks organism_age field but cifies organism_age_unit (#5264) Hotfix: Metadata for donor_organism lacks organism_age field but specifies organism_age_unit (#5264) Jun 2, 2023
@achave11-ucsc achave11-ucsc changed the title Hotfix: Metadata for donor_organism lacks organism_age field but specifies organism_age_unit (#5264) Hotfix: Metadata for donor_organism lacks organism_age field but specifies organism_age_unit (#5264) Jun 2, 2023
@achave11-ucsc achave11-ucsc mentioned this pull request Jun 2, 2023
39 tasks
@hannes-ucsc hannes-ucsc changed the title Hotfix: Metadata for donor_organism lacks organism_age field but specifies organism_age_unit (#5264) Hotfix: Unit without value for donor age in project 5f607e50 (#5264) Jun 2, 2023
@hannes-ucsc hannes-ucsc added 0 reviews [process] Lead didn't request any changes no sandbox [process] PR will not be tested in the sandbox labels Jun 2, 2023
@achave11-ucsc achave11-ucsc merged commit 298c42a into prod Jun 2, 2023
@achave11-ucsc achave11-ucsc deleted the hotfixes/achave11-ucsc/5264-remove-offending-project branch June 3, 2023 03:51
@achave11-ucsc achave11-ucsc removed their assignment Jun 3, 2023
dsotirho-ucsc added a commit that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 reviews [process] Lead didn't request any changes hotfix [process] An PR with an urgent fix for prod no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants