Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GitLab to stock Amazon Linux 2 AMI (#4188, #3942) #4449

Merged
merged 10 commits into from
Sep 20, 2022

Conversation

hannes-ucsc
Copy link
Member

@hannes-ucsc hannes-ucsc commented Sep 14, 2022

Connected issue: #4188, #3942

Continued from: #4443

Checklist

Author

  • Target branch is develop
  • Name of source branch matches issues/<GitHub handle of author>/<issue#>-<slug>
  • PR title references the connected issue
  • PR title matches1 title of connected issue or comment in PR explains why they're different
  • Title of at least one commit references connected issue
  • PR is connected to issue via Zenhub
  • PR description links to connected issue
  • Added partial label to PR or this PR completely resolves the connected issue

1 when the issue title describes a problem, the PR title is Fix: followed by the issue title

Author (reindex)

  • Added r tag to commit title or this PR does not require reindexing
  • Added reindex label to PR or this PR does not require reindexing

Author (chains)

  • This PR is blocked by previous PR in the chain or this PR is not chained to another PR
  • Added base label to the blocking PR or this PR is not chained to another PR
  • Added chained label to this PR or this PR is not chained to another PR

Author (upgrading)

  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading
  • Added u tag to commit title or this PR does not require upgrading
  • Added upgrade label to PR or this PR does not require upgrading

Author (operator tasks)

  • Added checklist items for additional operator tasks or this PR does not require additional tasks

Author (hotfixes)

  • Added F tag to main commit title or this PR does not include permanent fix for a temporary hotfix
  • Reverted the temporary hotfix connected to the issue or there is no temporary hotfix for the connected issue on the prod branch

Author (requirements)

  • Ran make requirements_update or this PR does not touch requirements*.txt, common.mk, Makefile and Dockerfile
  • Added R tag to commit title or this PR does not touch requirements*.txt
  • Added reqs label to PR or this PR does not touch requirements*.txt

Author (rebasing, integration test)

  • make integration_test passes in personal deployment or this PR does not touch functionality that could break the IT
  • Rebased branch on develop, squashed old fixups

Peer reviewer (after requesting changes)

Uncheck the Author (requirements) and Author (rebasing, integration test)
checklists.

Peer reviewer (after approval)

  • Ticket is in Review requested column
  • Requested review from primary reviewer
  • Assigned PR to primary reviewer

Primary reviewer (after requesting changes)

Uncheck the Author (requirements) and Author (rebasing, integration test)
checklists. Update the N reviews label.

Primary reviewer (after approval)

  • Actually approved the PR
  • Labeled connected issue as demo or no demo
  • Commented on connected issue about demo expectations or labelled connected issue as no demo
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • N reviews label is accurate
  • Moved ticket to Approved column
  • Assigned PR to current operator

Operator (before pushing merge the commit)

  • Deployed to dev.gitlab
  • Deployed to prod.gitlab
  • Deployed to anvildev.gitlab
  • Checked reindex label and r commit title tag
  • Checked that demo expectations are clear or connected issue is labeled as no demo
  • Rebased and squashed branch
  • Sanity-checked history
  • Pushed PR branch to GitHub
  • Branch pushed to GitLab and added sandbox label or PR is labeled no sandbox
  • Build passed in sandbox or PR is labeled no sandbox
  • Deleted unreferenced indices in sandbox or this PR does not remove catalogs or otherwise causes unreferenced indices
  • Started reindex in sandbox or this PR does not require reindexing sandbox
  • Checked for failures in sandbox or this PR does not require reindexing sandbox
  • Added PR reference to merge commit title
  • Collected commit title tags in merge commit title
  • Moved connected issue to Merged column
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Shortened the PR chain or this PR is not labeled base
  • Pushed merge commit to GitLab or PR is labeled no sandbox
  • Deleted PR branch from GitHub and GitLab
  • Build passes on GitLab1

1 When pushing the merge commit is skipped due to the PR being
labelled no sandbox, the next build triggered by a PR whose merge commit is
pushed determines this checklist item.

Operator (reindex)

  • Deleted unreferenced indices in dev or this PR does not remove catalogs or otherwise causes unreferenced indices
  • Started reindex in dev or this PR does not require reindexing
  • Checked for and triaged indexing failures or this PR does not require reindexing
  • Emptied fail queues in target deployment or this PR does not require reindexing

Operator

  • Confirmed that clamscan and prune-images jobs ran on the weekend after this was deployed to dev.gitlab
  • Confirmed that clamscan and prune-images jobs ran on the weekend after this was deployed to prod.gitlab
  • Confirmed that clamscan and prune-images jobs ran on the weekend after this was deployed to anvildev.gitlab
  • Unassigned PR

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@github-actions github-actions bot added the orange [process] Done by the Azul team label Sep 14, 2022
@hannes-ucsc hannes-ucsc changed the title Issues/hannes ucsc/4188 amazon linux Switch GitLab to stock Amazon Linux 2 AMI (#4188) Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #4449 (5793e41) into develop (49aff4c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4449   +/-   ##
========================================
  Coverage    82.11%   82.11%           
========================================
  Files          131      131           
  Lines        16312    16312           
========================================
  Hits         13394    13394           
  Misses        2918     2918           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

coveralls commented Sep 14, 2022

Coverage Status

Coverage remained the same at 82.364% when pulling 5793e41 on issues/hannes-ucsc/4188-amazon-linux into 49aff4c on develop.

@hannes-ucsc hannes-ucsc changed the title Switch GitLab to stock Amazon Linux 2 AMI (#4188) Switch GitLab to stock Amazon Linux 2 AMI (#4188, #3942) Sep 14, 2022
@achave11-ucsc achave11-ucsc force-pushed the issues/hannes-ucsc/4188-amazon-linux branch from db720ad to a04d7c1 Compare September 15, 2022 17:05
@achave11-ucsc achave11-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label Sep 15, 2022
@achave11-ucsc achave11-ucsc force-pushed the issues/hannes-ucsc/4188-amazon-linux branch from c3479b7 to 5793e41 Compare September 20, 2022 06:22
@achave11-ucsc achave11-ucsc merged commit ea93843 into develop Sep 20, 2022
@achave11-ucsc achave11-ucsc deleted the issues/hannes-ucsc/4188-amazon-linux branch September 20, 2022 15:02
@achave11-ucsc achave11-ucsc removed their assignment Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orange [process] Done by the Azul team sandbox [process] Resolution is being verified in sandbox deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants