Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitLab to 14.7.7 (#4014) #4079

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Update GitLab to 14.7.7 (#4014) #4079

merged 1 commit into from
Apr 12, 2022

Conversation

amarjandu
Copy link
Contributor

@amarjandu amarjandu commented Apr 11, 2022

Connected issue: #4014

Checklist

Author

  • Target branch is develop
    - [ ] Source branch is issues/<github-handle>/<issue#>-<slug>
  • PR title references the connected issue
    - [ ] PR title matches1 title of connected issue or comment in PR explains why they're different
  • Title of at least one commit references connected issue
  • PR is connected to issue via Zenhub
  • PR description links to connected issue
    - [ ] Added partial label to PR or this PR completely resolves the connected issue

1 when the issue title describes a problem, the PR title is Fix: followed by the issue title

Author (reindex)

  • Added r tag to commit title or this PR does not require reindexing
  • Added reindex label to PR or this PR does not require reindexing

Author (chains)

  • This PR is blocked by previous PR in the chain or this PR is not chained to another PR
  • Added chain label to the blocking PR or this PR is not chained to another PR

Author (upgrading)

  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading
  • Added u tag to commit title or this PR does not require upgrading
  • Added upgrade label to PR or this PR does not require upgrading

Author (operator tasks)

  • Added checklist items for additional operator tasks or this PR does not require additional tasks

Author (hotfixes)

  • Added F tag to main commit title or this PR does not include permanent fix for a temporary hotfix
  • Reverted the temporary hotfix connected to the issue or there is no temporary hotfix for the connected issue on the prod branch

Author (requirements)

  • Ran make requirements_update or this PR does not touch requirements*.txt, common.mk, Makefile and Dockerfile
  • Added R tag to commit title or this PR does not touch requirements*.txt
  • Added reqs label to PR or this PR does not touch requirements*.txt

Author (rebasing, integration test)

  • make integration_test passes in personal deployment or this PR does not touch functionality that could break the IT
  • Rebased branch on develop, squashed old fixups

Primary reviewer (after rejection)

Uncheck the Author (requirements) and Author (rebasing, integration test)
checklists.

Primary reviewer (after approval)

  • Actually approved the PR
  • Labeled connected issue as demo or no demo
  • Commented on connected issue about demo expectations or labelled connected issue as no demo
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Ticket is in Review requested column
  • Requested review from peer reviewer
  • Assigned PR to peer reviewer

Peer reviewer (after rejection)

Uncheck the Author (requirements) and Author (rebasing, integration test)
checklists.

Peer reviewer (after approval)

  • N reviews label on PR reflects prior peer reviews with changes requested
  • Moved ticket to Approved column
  • Assigned PR to current operator

Operator (before pushing merge the commit)

  • Checked reindex label and r commit title tag
  • Checked that demo expectations are clear or connected issue is labeled as no demo
  • Rebased and squashed branch
  • Sanity-checked history
  • Pushed PR branch to GitHub
  • Branch pushed to GitLab and added sandbox label or PR is labeled no sandbox
  • Build passed in sandbox or PR is labeled no sandbox
  • Deleted unreferenced indices in sandbox or this PR does not remove catalogs or otherwise causes unreferenced indices
  • Started reindex in sandbox or this PR does not require reindexing sandbox
  • Checked for failures in sandbox or this PR does not require reindexing sandbox
  • Added PR reference to merge commit title
  • Collected commit title tags in merge commit title
  • Moved connected issue to Merged column
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Shortened the PR chain or this PR is not labeled chain
  • Pushed merge commit to GitLab or merge commit can be pushed later, with another PR
  • Deleted PR branch from GitHub and GitLab
  • Build passes on GitLab

Operator (reindex)

  • Deleted unreferenced indices in dev or this PR does not remove catalogs or otherwise causes unreferenced indices
  • Started reindex in dev or this PR does not require reindexing
  • Checked for and triaged indexing failures or this PR does not require reindexing
  • Emptied fail queues in target deployment or this PR does not require reindexing

Operator

  • Unassigned PR

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@github-actions github-actions bot added the orange [process] Done by the Azul team label Apr 11, 2022
@amarjandu amarjandu mentioned this pull request Apr 11, 2022
48 tasks
@coveralls
Copy link

coveralls commented Apr 11, 2022

Coverage Status

Coverage remained the same at 82.187% when pulling 4314ef5 on gitlab/2022-04-11 into 21c8395 on develop.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #4079 (4314ef5) into develop (21c8395) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4079   +/-   ##
========================================
  Coverage    81.97%   81.97%           
========================================
  Files          124      124           
  Lines        15138    15138           
========================================
  Hits         12410    12410           
  Misses        2728     2728           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c8395...4314ef5. Read the comment docs.

@amarjandu amarjandu assigned amarjandu and hannes-ucsc and unassigned amarjandu Apr 11, 2022
@hannes-ucsc hannes-ucsc added no sandbox [process] PR will not be tested in the sandbox partial [process] PR is does not completely resolve associated ticket labels Apr 11, 2022
@hannes-ucsc hannes-ucsc assigned amarjandu and unassigned hannes-ucsc Apr 11, 2022
@amarjandu amarjandu merged commit 73059a2 into develop Apr 12, 2022
@amarjandu amarjandu deleted the gitlab/2022-04-11 branch April 12, 2022 00:18
@amarjandu amarjandu removed their assignment Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team partial [process] PR is does not completely resolve associated ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants