Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eradicate singlecell.gi.ucsc.edu from the top-level environment file #1528

Closed
jessebrennan opened this issue Feb 1, 2020 · 2 comments
Closed
Assignees
Labels
debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team enh [type] New feature or request infra [subject] Project infrastructure like CI/CD, build and deployment scripts orange [process] Done by the Azul team

Comments

@jessebrennan
Copy link
Contributor

No description provided.

@hannes-ucsc
Copy link
Member

Consider adding this as well

Index: deployments/.example.local/environment.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- deployments/.example.local/environment.py	(revision 5a97e209d85d857dda34cd981b0c4f12f4eeec84)
+++ deployments/.example.local/environment.py	(date 1586463228335)
@@ -1,4 +1,11 @@
-from typing import Optional, Mapping
+from typing import (
+    Mapping,
+    Optional,
+)
+
+# Whether to share the ES domain with the `dev` deployment
+#
+share_es_domain = True
 
 
 def env() -> Mapping[str, Optional[str]]:
@@ -16,7 +23,7 @@
     Entries with a None value will be excluded from the environment. They should 
     be used to document variables without providing a default value. Other,
     usually more specific environment.py files should provide the value.
-    """ 
+    """
     return {
         # Set variables for the personal `yourname` deployment here.
         #
@@ -35,28 +42,34 @@
         'AZUL_DSS_ENDPOINT': 'https://dss.staging.data.humancellatlas.org/v1',
         'AZUL_DSS_DIRECT_ACCESS': '1',
         'AZUL_DSS_DIRECT_ACCESS_ROLE': 'arn:aws:iam::861229788715:role/azul-{{lambda_name}}-staging',
-        
+
         # A personal deployment uses a subdomain of the `dev` deployment's domain.
         #
         'AZUL_DOMAIN_NAME': 'dev.singlecell.gi.ucsc.edu',
         'AZUL_SUBDOMAIN_TEMPLATE': '{{lambda_name}}.{AZUL_DEPLOYMENT_STAGE}',
-        
+
         'AZUL_URL_REDIRECT_BASE_DOMAIN_NAME': 'dev.url.singlecell.gi.ucsc.edu',
         'AZUL_URL_REDIRECT_FULL_DOMAIN_NAME': '{AZUL_DEPLOYMENT_STAGE}.{AZUL_URL_REDIRECT_BASE_DOMAIN_NAME}',
-        
-        # A personal deployment shares an ES domain with `dev`
-        #
-        'AZUL_SHARE_ES_DOMAIN': '1',
-        'AZUL_ES_DOMAIN': 'azul-index-dev',
-        
+
+        **({
+               'AZUL_SHARE_ES_DOMAIN': '1',
+               'AZUL_ES_DOMAIN': 'azul-index-dev',
+           } if share_es_domain else {
+            'AZUL_SHARE_ES_DOMAIN': '0',
+            'AZUL_ES_DOMAIN': 'azul-index-{AZUL_DEPLOYMENT_STAGE}',
+            'AZUL_ES_INSTANCE_TYPE': 'r4.xlarge.elasticsearch',
+            'AZUL_ES_INSTANCE_COUNT': '2',
+            'AZUL_ES_VOLUME_SIZE': 10
+        }),
+
         'azul_dss_query_prefix': '42',
-        
+
         'AZUL_DEBUG': '1',
-        
+
         'AZUL_OWNER': '<your_email>',
-        
+
         'AWS_DEFAULT_REGION': 'us-east-1',
-        
+
         # Indexer Lambdas in personal deployments do not require default reserved concurrency
         'AZUL_INDEXER_CONCURRENCY': '8',
         

@theathorn theathorn added debt [type] A defect incurring continued engineering cost infra [subject] Project infrastructure like CI/CD, build and deployment scripts labels Jan 25, 2021
@hannes-ucsc hannes-ucsc added the enh [type] New feature or request label Nov 5, 2021
@hannes-ucsc hannes-ucsc self-assigned this Jul 27, 2022
@hannes-ucsc hannes-ucsc changed the title Eradicate deployment specifics (i.e. HCA, Platform-SC) from the top-level environment file Eradicate singlecell.gi.ucsc.edu from the top-level environment file Jul 27, 2022
@hannes-ucsc hannes-ucsc added no demo [process] Not to be demonstrated at the end of the sprint demo [process] To be demonstrated at the end of the sprint and removed no demo [process] Not to be demonstrated at the end of the sprint labels Aug 4, 2022
@hannes-ucsc
Copy link
Member

For demo, show that singlecell is gone from environment.py at project root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team enh [type] New feature or request infra [subject] Project infrastructure like CI/CD, build and deployment scripts orange [process] Done by the Azul team
Projects
None yet
Development

No branches or pull requests

4 participants