Skip to content

Commit

Permalink
Fix: PR checklist should mention unchaining steps (#5190)
Browse files Browse the repository at this point in the history
  • Loading branch information
dsotirho-ucsc authored and achave11-ucsc committed May 23, 2023
1 parent 22e4de6 commit 3436a8f
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 13 deletions.
9 changes: 8 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/gitlab.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,16 @@ Connected issue: #4014
- [ ] Pushed merge commit to GitHub


### Operator (chain shortening)

- [ ] Changed the target branch of the blocked PR to `develop` <sub>or this PR is not labeled `base`</sub>
- [ ] Removed the `chained` label from the blocked PR <sub>or this PR is not labeled `base`</sub>
- [ ] Removed the blocking relationship from the blocked PR <sub>or this PR is not labeled `base`</sub>
- [ ] Removed the `base` label from this PR <sub>or this PR is not labeled `base`</sub>


### Operator (after pushing the merge commit)

- [ ] Shortened the PR chain <sub>or this PR is not labeled `base`</sub>
- [ ] Deleted PR branch from GitHub


Expand Down
9 changes: 8 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,16 @@ Uncheck the *before every review* checklists. Update the `N reviews` label.
- [ ] Pushed merge commit to GitHub


### Operator (chain shortening)

- [ ] Changed the target branch of the blocked PR to `develop` <sub>or this PR is not labeled `base`</sub>
- [ ] Removed the `chained` label from the blocked PR <sub>or this PR is not labeled `base`</sub>
- [ ] Removed the blocking relationship from the blocked PR <sub>or this PR is not labeled `base`</sub>
- [ ] Removed the `base` label from this PR <sub>or this PR is not labeled `base`</sub>


### Operator (after pushing the merge commit)

- [ ] Shortened the PR chain <sub>or this PR is not labeled `base`</sub>
- [ ] Pushed merge commit to GitLab `dev` <sub>or PR is labeled `no sandbox`</sub>
- [ ] Pushed merge commit to GitLab `anvildev` <sub>or PR is labeled `no sandbox`</sub>
- [ ] Build passes on GitLab `dev`<sup>1</sup>
Expand Down
23 changes: 19 additions & 4 deletions .github/pull_request_template.md.template.py
Original file line number Diff line number Diff line change
Expand Up @@ -598,14 +598,29 @@ def main():
'type': 'cli',
'content': 'Pushed merge commit to GitHub'
},
*iif(t in (T.default, T.gitlab), [
{
'type': 'h2',
'content': 'Operator (chain shortening)'
},
*[
{
'type': 'cli',
'content': content,
'alt': 'or this PR is not labeled `base`'
}
for content in [
'Changed the target branch of the blocked PR to `develop`',
'Removed the `chained` label from the blocked PR',
'Removed the blocking relationship from the blocked PR',
'Removed the `base` label from this PR'
]
]
]),
{
'type': 'h2',
'content': 'Operator (after pushing the merge commit)'
},
iif(t in (T.default, T.gitlab), {
'type': 'cli',
'content': 'Shortened the PR chain', 'alt': 'or this PR is not labeled `base`'
}),
*[
{
'type': 'cli',
Expand Down
7 changes: 0 additions & 7 deletions OPERATOR.rst
Original file line number Diff line number Diff line change
Expand Up @@ -232,13 +232,6 @@ For an example of how to document failures within a PR `click here`_.

.. _click here: https://github.com/DataBiosphere/azul/pull/3050#issuecomment-840033931

Chain shortening
^^^^^^^^^^^^^^^^

Change the target branch of the blocked PR to ``develop`` and remove the ``chained``
label from that PR. Remove the ``base`` label from the blocking PR. Lastly, remove the blocking
relationship.

Updating the AMI for GitLab instances
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down

0 comments on commit 3436a8f

Please sign in to comment.