Added liveUpdateTimeThreshold to control time syncing during live streams #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me updates during live streams
matvp91
changed the title
dsilhavy
requested changes
Feb 5, 2024
dsilhavy
approved these changes
Feb 6, 2024
dsilhavy
merged commit 9e3da3c
into
Dash-Industry-Forum:development
1 of 3 checks passed
eirikbjornr
pushed a commit
to bbc/dash.js
that referenced
this pull request
Feb 14, 2024
…eams (Dash-Industry-Forum#4382) * Added liveUpdateTimeThresholdInMilliseconds in order to control the frequency of time updates during live streams
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On low end devices, we noticed an increasing burden on the CPU during live streams. This setting adds a threshold that must be passed in order for
PlaybackControllerto push another time sync instruction during dynamic manifests.This is very comparable to
wallclockTimeUpdateIntervalbut it does not interfere with other logic based on wall clock such as gap jumping (which is a way less heavy instruction for low end CPU's to handle).