-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset MSE when switching codec if changeType is unstable or unavailable #4270
Reset MSE when switching codec if changeType is unstable or unavailable #4270
Conversation
@dsilhavy as discussed on Slack, |
@matvp91 This looks good to me.
|
…urceBuffersForTrackSwitch
@dsilhavy Got it, I'll give this some final runs on a variety of webOS devices where this applies and we're all good after that I believe. Thanks for the info! |
@dsilhavy tested this on a variety of webOS devices and all looks good. Guess we're good to go! |
…le (Dash-Industry-Forum#4270) * resetSourceBuffersForTrackSwitch
Noticed on webOS 4, when switching audio track from one codec to another. A MEDIA_ERR_DECODE error is thrown and
_handleMediaErrorDecode
resets MSE. Waiting for decode error to occur is not favourable, thus introducing a new buffer settingresetSourceBuffersForTrackSwitch
that resets MSE when we're switching to a new track with a different codec than the active track.