Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait until buffer is ready when changing timestamp offset #2595

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Wait until buffer is ready when changing timestamp offset #2595

merged 1 commit into from
Jun 6, 2018

Conversation

aescarcha
Copy link
Contributor

Fixes #2533

@epiclabsDASH epiclabsDASH added this to the 2.8 milestone May 29, 2018
@epiclabsDASH epiclabsDASH changed the title Waiting until buffer is ready when changing timestamp offset Wait until buffer is ready when changing timestamp offset May 30, 2018
@aescarcha aescarcha force-pushed the secureBufferTimestampOffsetChange branch from af5cb20 to 4fff574 Compare June 5, 2018 13:52
@aescarcha aescarcha force-pushed the secureBufferTimestampOffsetChange branch from 4fff574 to 688d559 Compare June 5, 2018 14:06
@epiclabsDASH
Copy link
Contributor

The idea behind this change is using a queue to sequentially execute operations on the SourceBuffer: append/remove buffers and changes of timestampOffset property.

@epiclabsDASH epiclabsDASH merged commit 640da28 into Dash-Industry-Forum:development Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@aescarcha @epiclabsDASH