Fixed an edge issue causing text track to stop working when seeking back #2527
Conversation
…o a previous time
|
From @padninja:
|
| @@ -348,6 +348,8 @@ function TextSourceBuffer() { | |||
| result = parser.parse(ccContent, offsetTime, sampleStart / timescale, (sampleStart + sample.duration) / timescale, images); | |||
| textTracks.addCaptions(currFragmentedTrackIdx, firstSubtitleStart / timescale, result); | |||
| } catch (e) { | |||
| fragmentModel.removeExecutedRequestsBeforeTime(Date.now()); | |||
There was a problem hiding this comment.
No need to call Date.now(), an empty argument will remove all the executed requests.
There was a problem hiding this comment.
That would cause a comparison of a number and undefined - number, that's number >= NaN. I don't really like that, but I'll change it if it's necessary
There was a problem hiding this comment.
Hi @aescarcha ,
sorry I don't see where the problem is. If time is undefined, the filter function of the array will return false. Do I miss something?
Nico
There was a problem hiding this comment.
Hi @nicosang It's just that it looks a bit obscure for me. I'll remove it now.
addCuemethod crashed withInvalid argumentafter seeking back, a simple track reset if the exception happens fixes this. #2524