Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2184
This PR changes the behavior of PlaybackController so it operates with VideoModel only in case PlaybackController was previously initialized and then there is an active stream. Otherwise, there are situations in which a call to MediaPlayer.play() before stream is initialized (and then the MediaSource associated) brings video element to an unstable state and some of its events are not fired (for example, the "play" event that is used to launch processes like the manifest update one). Example code to reproduce the issue:
This is broken since v2.6.0. Dash.js v2.5.0 and before were working fine because they were establishing the video element during PlaybackController initialization.