Revert ProtectionController #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…system access error
|
@dsparacio, do you remind why was done in that way (not triggering error when selecting key system from manifest)? @bbert, why do you think it could be done to give more priority to key systems in the stream? I could be missing something but I don't see any mechanism that tries keysystems of the stream that is related with the triggering or not of that event. |
|
To give more priority to key systems in the pssh from the stream is my interpretation of the mechanism that consist in trigerring an error only if the key system is being selected on 'needkey' event (which is raised when init segment and its pssh is pushed into buffer). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a modification mistakenly done in PR #2435.
That concerns key system access error not being triggered when selecting key system from manifest.
BTW, does anyone know why it has been done this way? I thought it could be to handle use case where key systems declared in manifest can't be accessed while pssh of additional key systems are contained in the stream. Then it gives priority to pssh in the stream.
Can anyone confirm or complete?