onManifestUpdated and getStreamsInfo optimizations #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
reviewed
Feb 27, 2018
src/dash/DashAdapter.js
Outdated
| @@ -309,7 +309,7 @@ function DashAdapter() { | |||
| voAdaptations = {}; | |||
| } | |||
|
|
|||
| function getStreamsInfo(externalManifest) { | |||
| function getStreamsInfo(externalManifest, limit) { | |||
There was a problem hiding this comment.
@Gontran-Molotov , it could be interesting to rename limit parameter by, for instance, maxStreamsInfo
There was a problem hiding this comment.
That's indeed a more explicit variable name. Thanks for the suggestion.
Gontran-Molotov
force-pushed
the
optimizeOnManifestUpdate
branch
from
77f060d to
463cb67
Compare
|
Fix conflict with ProtectionController.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the
StreamController.onManifestUpdated()method. It removes the manifest passed as argument toadapter.getStreamsInfo()because theDashAdapterinstance already got regular periods for the current manifest. So it is useless to re-analyze the manifest once again to get them.This PR also adds a new
limitargument toDashAdapter.getStreamsInfo(). It allows to specify for how many streams we want to get info. Currently, some classes callsgetStreamInfos()to uselessly get info for all streams but only use the first one.