Fix issue with live stream thumbnails #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Now, the correct thumbnail images are fetched. It is not obvious to me what time-values one shall have on a scrub-bar for live, but as long as the values are aligned with the scrub-bar itself as it is now, I'm fine. I think the PR is fine with the livesim-dev URL. Once I've updated the main livesim instance, I'll make a PR to change the URL to point to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2359 and then enable Thumbnails support for live streams.
@TobbeEdgeware, for your information, I have added the live stream with thumbnails stream that you created to the Dash reference player list of sample streams. Thanks to it I was able to detect the issue. Thanks!