Fix #2355 - check for correct DOM error on XML parse failure #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Just replaced xmldom with jsdom and everything worked fine, so we can remove xmldom safely and cut out a dependency. There is just one drawback on using jsdom: xmldom size is about 73Kb, jsdom is 2Mb. Anyway, given it is a dev dependency, size shouldn't be our biggest problem. This is going to impact a bit our build time in travis although I don't expect big differences (note: at some point we need to enable Travis cache mechanism for deps). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a test.
Requires jsdom as no other node xml parser I can find seems to follow the spec wrt
parsererror. We could consider replacing xmldom used elsewhere to cut out a dev dependency.