Subtitles track with same lang bug #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e deleted when text track switch occurs.
…track switch occurs.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to solve issues about subtitles.
A subtitle track may have same kind, label and lang but a different format (vtt, ttml, etc...). We have to be able to distinguish both tracks.
When text track switch occurs, all cues are deleted but executedRequests array was not cleaned. So, when the user seeked back, subtitles was not downloaded again.
Both issues can be reproduced with the stream https://media.axprod.net/TestVectors/v8-MultiContent/Clear/Manifest.mpd. The default text track didn't show due to first issue. Change text track selection and seek back in order to see second issue.
Nico