-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional tests with browserStack #2243
Functional tests with browserStack #2243
Conversation
d84c119
to
57036c4
Compare
2966749
to
5ad668b
Compare
package.json
Outdated
"debug-mocha": "iron-node node_modules/mocha/bin/_mocha --require mochahook", | ||
"test": "mocha test/unit --require mochahook", | ||
"test-unit": "mocha test/unit --require mochahook", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we keep "test" script for unit tests and use "test-functional" for functional testing? Just to keep script actions as they were before this change and for consistency with other projects. Most of developers expect npm run test to be unit testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test stage of travis is the main problem, it starts the test script defined in the package.json. I have to discuss this point with @bbert but I think that we tried to call a specific test script in the travis.yml : it didn't work. :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Please, let me know if it finally worked. Otherwise we can do as you proposed.
Sorry, there are some conflicts to be resolve after latest merges. |
RemoteDashJSServer needs to be changed.
BrowserStack username and acces_key needs to be updated. functional tests are executed only on cron jobs. Those jobs are defined in travis settings page.
- add stages configuration to run: - build job each time - functional tests job only on cron job - add matrix for functional tests to have one job per browser
- 'matrix' must be in 'env' section - test not running build stage if cron job
84cf860
to
8d3d961
Compare
Hi,
this PR suggests to use functional test page of #2242 PR to execute tests on a browserStack service. As previously, build process is executed on each branch with Travis. Functional tests are executed only on branch on which a travis cron job has been defined. Some informations have to be updated like :
Nico