Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests with browserStack #2243

Conversation

nicosang
Copy link
Contributor

Hi,

this PR suggests to use functional test page of #2242 PR to execute tests on a browserStack service. As previously, build process is executed on each branch with Travis. Functional tests are executed only on branch on which a travis cron job has been defined. Some informations have to be updated like :

  • browserStack username
  • browserStack accesskey
  • deployed functional test page

Nico

@nicosang nicosang force-pushed the functionalTestsWithBrowserStack branch from d84c119 to 57036c4 Compare October 30, 2017 13:15
@epiclabsDASH epiclabsDASH added this to the v2.6.4 milestone Nov 1, 2017
@nicosang nicosang force-pushed the functionalTestsWithBrowserStack branch from 2966749 to 5ad668b Compare November 2, 2017 08:37
package.json Outdated
"debug-mocha": "iron-node node_modules/mocha/bin/_mocha --require mochahook",
"test": "mocha test/unit --require mochahook",
"test-unit": "mocha test/unit --require mochahook",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep "test" script for unit tests and use "test-functional" for functional testing? Just to keep script actions as they were before this change and for consistency with other projects. Most of developers expect npm run test to be unit testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test stage of travis is the main problem, it starts the test script defined in the package.json. I have to discuss this point with @bbert but I think that we tried to call a specific test script in the travis.yml : it didn't work. :-(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Please, let me know if it finally worked. Otherwise we can do as you proposed.

@epiclabsDASH
Copy link
Contributor

Sorry, there are some conflicts to be resolve after latest merges.

nicosang and others added 12 commits November 21, 2017 17:01
BrowserStack username and acces_key needs to be updated.
functional tests are executed only on cron jobs. Those jobs are defined in travis settings page.
- add stages configuration to run:
  - build job each time
  - functional tests job only on cron job
- add matrix for functional tests to have one job per browser
- 'matrix' must be in 'env' section
- test not running build stage if cron job
@nicosang nicosang force-pushed the functionalTestsWithBrowserStack branch from 84cf860 to 8d3d961 Compare November 21, 2017 16:24
@epiclabsDASH epiclabsDASH merged commit 771f89f into Dash-Industry-Forum:development Nov 28, 2017
@bbert bbert deleted the functionalTestsWithBrowserStack branch July 10, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants