Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual progress indicators #3

Merged
merged 13 commits into from
Dec 13, 2024
Merged

Add visual progress indicators #3

merged 13 commits into from
Dec 13, 2024

Conversation

Daru-san
Copy link
Owner

@Daru-san Daru-san commented Dec 12, 2024

Introduction

In this pull my goal is to create visual indicators for running operations.

It is supposed to be a continuation on #1, this time focusing solely on expanding on the TaskQueue and adding visual indicators of progress.

Goals

  • Add visual indication of tasks
  • Abort with helpful errors showing exact stage of failure
  • Sync progress with TaskQueue operations

@Daru-san Daru-san added the enhancement New feature or request label Dec 12, 2024
@Daru-san Daru-san self-assigned this Dec 12, 2024
@Daru-san
Copy link
Owner Author

So far, I have been considering using the TaskQueue along with the GlobalProgress struct implemented in this pr to track and display progress on current tasks.
I am not necessarily sure about how I will co-ordinate them, whether the task queue will handle both tasks and displaying progress or whether I will have to wrap that functionality in a whole other struct.

However I want to avoid too much encapsulation as to avoid the overhead of multiple different structs contained in other structs (somehow) interacting with each other.
At the same time, I do not want to make my run and run_batch functions too long, as that would become difficult to read.

@Daru-san
Copy link
Owner Author

Due to a realization that error handling is still incomplete, I will merge my current progress and work on error handling.
This pr has changes that I would need to flesh out and that require that I complete error handling as a proper feature.

This merge is very early, which is a result of incomplete error
handling.
I will move on to deal with that issue and move back to visual
indicators in a later pr
@Daru-san Daru-san merged commit 1637a0d into main Dec 13, 2024
7 of 10 checks passed
@Daru-san Daru-san deleted the feat/progress-indicators branch December 14, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant