-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to System.IO.Ports, combine projects into a single NuGet package #29
Conversation
…ined `OBD.NET.Desktop` with `OBD.NET.Common`
Hey, thanks for contributing :) To give you a status update on this: |
Ahh didn't check for that. |
Finally got some time to finish reviewing and testing this - thanks again for contributing :) This should indeed fix #22 |
Solves a part of #22.
Changed the
SerialConnector
to use the cross-platformSystem.IO.Ports
package, because the earlier usedEnhancedSerialConnector
raised an exception when trying to use it with .NET 5/6 on Linux or macOS.This PR also aims to combine the
OBD.NET.Desktop
with theOBD.NET.Common
project, to simplify the use of this package. The code was also refactored to C# 10.The
OBD.NET.Universal
project should continue to work with this implementation, though I couldn't test it on my own due to a lack of the required hardware. It build successfully and I couldn't see any reasons, why it shouldn't continue to work.The new
OBD.NET
package was tested on macOS/Linux (Raspberry Pi) and worked just fine.