Skip to content

Commit

Permalink
roachtest: assign adminui ports dynamically for virtual clusters
Browse files Browse the repository at this point in the history
This was originally removed in cockroachdb#115599 due to cockroachdb#114097 merging,
but adminui was reverted in cockroachdb#117141 and mistakenly did not
revert the special case for virtual clusters.

Release note: None
  • Loading branch information
DarrylWong committed Jan 16, 2024
1 parent c6a8fd7 commit 928ed7d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/cmd/roachtest/option/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ func DefaultStartVirtualClusterOpts(tenantName string, sqlInstance int) StartOpt
startOpts.RoachprodOpts.Target = install.StartServiceForVirtualCluster
startOpts.RoachprodOpts.VirtualClusterName = tenantName
startOpts.RoachprodOpts.SQLInstance = sqlInstance
// TODO(DarrylWong): remove once #117125 is addressed.
startOpts.RoachprodOpts.AdminUIPort = 0
return startOpts
}

Expand Down

0 comments on commit 928ed7d

Please sign in to comment.