Recover soil/crop recipe ids from their respective itemstacks #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quezler
added a commit
to Quezler/Enigmatica6
that referenced
this pull request
May 18, 2022
Awaiting one or both of these getting merged: Darkhax-Minecraft/BotanyPots#227 Darkhax-Minecraft/BotanyPots#226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to be able to recover from (temporarily) deleted json files and (temporarily) renamed json files. (& recompiling)
The messages written to
BotanyPots.LOGGER.erroraren't yet updated to reflect that the crop "might not" be discarded because of the new recovery attempt, before I touch this further I'll first await feedback from the author. (does he like it?)